Fix return type of QTableWidget.cellWidget#198
Merged
altendky merged 3 commits intopython-qt-tools:masterfrom Nov 22, 2022
mkrieger1:master
Merged
Fix return type of QTableWidget.cellWidget#198altendky merged 3 commits intopython-qt-tools:masterfrom mkrieger1:master
altendky merged 3 commits intopython-qt-tools:masterfrom
mkrieger1:master
Conversation
Collaborator
|
Looking at fixing |
altendky
approved these changes
Nov 22, 2022
Collaborator
|
I hope you don't mind me jumping in and pushing a few details here. Just saves the back and forth which can be long when I know I haven't been particularly responsive. But, thanks for the correction! |
Contributor
Author
|
Sure, thanks! |
Collaborator
|
If you can add a test for this, that would be even better. The spirit of the tests is to run very small code snippets and make sure they typecheck correctly. |
Contributor
Author
|
I will look into it. |
mkrieger1
added a commit
to mkrieger1/PyQt5-stubs
that referenced
this pull request
Dec 16, 2022
altendky
added a commit
that referenced
this pull request
Dec 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cellWidgetreturns aQWidgetif it exists, orNoneif it doesn't exist.Confirmed by this short script:
Output: