Skip to content

Fixes annotation for QLineEdit to allow None as argument.#166

Merged
bluebird75 merged 22 commits into
python-qt-tools:masterfrom
altendky:playing_around
Jan 22, 2022
Merged

Fixes annotation for QLineEdit to allow None as argument.#166
bluebird75 merged 22 commits into
python-qt-tools:masterfrom
altendky:playing_around

Conversation

@altendky
Copy link
Copy Markdown
Collaborator

No description provided.

@bluebird75
Copy link
Copy Markdown
Collaborator

Try creating a QApplication with the follwing argv : -platform minimal

This should run on a gui-less environement.

@The-Compiler The-Compiler marked this pull request as ready for review November 29, 2021 21:15
@The-Compiler
Copy link
Copy Markdown
Collaborator

Whoops, that was unintended!

@The-Compiler The-Compiler marked this pull request as draft November 29, 2021 21:17
@bluebird75 bluebird75 mentioned this pull request Jan 3, 2022
@altendky
Copy link
Copy Markdown
Collaborator Author

I would rather stick with using a full platform plugin and letting pytest-xvfb help out on Linux.

@altendky altendky requested a review from bluebird75 January 16, 2022 15:22
Copy link
Copy Markdown
Collaborator

@bluebird75 bluebird75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me if it works on all platforms of the CI, let's go this way.

@altendky altendky marked this pull request as ready for review January 17, 2022 20:26
@altendky
Copy link
Copy Markdown
Collaborator Author

@bluebird75, you're tracking the changes more closely than I am. Go ahead and merge this when it fits.

@bluebird75 bluebird75 merged commit 6b964eb into python-qt-tools:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants