-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: announce poetry 1.8.0 #147
Conversation
Deploy preview for website ready! ✅ Preview Built with commit c1fb577. |
5a54dc8
to
87bb4d8
Compare
was inconsistent with the pyproject.toml. This happened if dependencies were changed | ||
in the pyproject.toml without running `poetry lock --no-update`. | ||
As a result, `poetry install` might fail or succeed with expected or unexpected results. | ||
This warning has been upgraded to an error to avoid issues that are hard to debug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to explain this change? I read it multiple times, but I still have no idea about what the change is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is certainly always room for improvement but I don't know how to explain it better. A warning becomes an error. In other words, the command will fail with return code unequal zero. If you have never seen the mentioned warning, it is probably irrelevant to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe everyone using poetry saw the warning multiple times 🙂 I'm not sure why, but I thought that "upgrade" comes with other changes, and the text was missing them. After rereading it, it feels clearer now. Let me share my other confusions, and the jury can decide if they need any updates:
- I'm missing how the
--no-update
parameter is relevant. I checked the PR and the discussions but couldn't find any reference. The only thing I saw was"Run
poetry lock [--no-update]to fix it.
on an unedited line, which I believe makes better sense, emphasizing that it's just an optional parameter. This happened if dependencies were changed in the pyproject.toml without running
This only covers a portion of the relevant cases shared by people on the PR. My understanding is the issue and the solution is more about the hash from the lock file not matching the relevant fields of thepyproject.toml
file than which file was edited by whom or for which purpose.
Also, thanks to confusion at the time, I did a terrible job explaining myself in the first comment. I hope it's more clear now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased the paragraph also considering the changed wording from python-poetry/poetry#8962. I hope it is clearer now. I still believe that changing something from warning to error can be called an upgrade but I am open to better wording. 😄
b02a329
to
c1fb577
Compare
No description provided.