Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: announce poetry 1.8.0 #147

Merged
merged 1 commit into from
Feb 25, 2024
Merged

blog: announce poetry 1.8.0 #147

merged 1 commit into from
Feb 25, 2024

Conversation

radoering
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 17, 2024

Deploy preview for website ready!

✅ Preview
https://website-o2xx37geo-python-poetry.vercel.app

Built with commit c1fb577.
This pull request is being automatically deployed with vercel-action

was inconsistent with the pyproject.toml. This happened if dependencies were changed
in the pyproject.toml without running `poetry lock --no-update`.
As a result, `poetry install` might fail or succeed with expected or unexpected results.
This warning has been upgraded to an error to avoid issues that are hard to debug.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to explain this change? I read it multiple times, but I still have no idea about what the change is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is certainly always room for improvement but I don't know how to explain it better. A warning becomes an error. In other words, the command will fail with return code unequal zero. If you have never seen the mentioned warning, it is probably irrelevant to you.

Copy link

@ulgens ulgens Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe everyone using poetry saw the warning multiple times 🙂 I'm not sure why, but I thought that "upgrade" comes with other changes, and the text was missing them. After rereading it, it feels clearer now. Let me share my other confusions, and the jury can decide if they need any updates:

  • I'm missing how the --no-update parameter is relevant. I checked the PR and the discussions but couldn't find any reference. The only thing I saw was "Run poetry lock [--no-update] to fix it. on an unedited line, which I believe makes better sense, emphasizing that it's just an optional parameter.
  • This happened if dependencies were changed in the pyproject.toml without running This only covers a portion of the relevant cases shared by people on the PR. My understanding is the issue and the solution is more about the hash from the lock file not matching the relevant fields of the pyproject.toml file than which file was edited by whom or for which purpose.

Also, thanks to confusion at the time, I did a terrible job explaining myself in the first comment. I hope it's more clear now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased the paragraph also considering the changed wording from python-poetry/poetry#8962. I hope it is clearer now. I still believe that changing something from warning to error can be called an upgrade but I am open to better wording. 😄

@radoering radoering requested a review from a team February 25, 2024 07:03
@radoering radoering marked this pull request as ready for review February 25, 2024 12:32
@abn abn merged commit 1fd2c91 into main Feb 25, 2024
3 checks passed
@abn abn deleted the release/1.8.0 branch February 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants