-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an official Poetry badge #119
Conversation
@Secrus If you could review, that'd be great. |
Deploy preview for website ready! ✅ Preview Built with commit dbdbcad. |
@johnthagen I was thinking something like: https://hatch.pypa.io/latest/next-steps/#community. |
@Secrus Let me know what you think of |
README.md
Outdated
@@ -1,9 +1,13 @@ | |||
# Poetry Website | |||
|
|||
This is the source of the official [Poetry website](https://python-poetry.org). | |||
[![Poetry](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/python-poetry/website/main/static/badge/v0.json)][official website] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[![Poetry](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/python-poetry/website/main/static/badge/v0.json)][official website] | |
[![Poetry](https://img.shields.io/endpoint?url=https://python-poetry.org/static/badge/v0.json)][official website] |
Could you make it so that this URL would work? I guess it would require some Hugo reconfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure I have the experience to make that work. The way it's implemented now is how Ruff's badge works, and it seemed like a good approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Secrus It looks like this could in fact work (from the preview website, I validated that /badge/v0.json
is accessible):
So the link would look like:
[![Poetry](https://img.shields.io/endpoint?url=https://python-poetry.org/badge/v0.json)][official website]
Is this what you prefer? I personally think routing it to GitHub is pretty simple, but if you'd prefer we point shields.io at the Poetry website instead, I'm happy to make the changes to the PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Secrus Just checking it to see if you wanted any more changes here.
Resolves: python-poetry/poetry#7270
Resolves: python-poetry/poetry#8011
logoSvg
was taken directly from the official Poetry website repo: https://github.com/python-poetry/website/blob/main/static/images/logo-origami.svgRelated documentation PR:
To test embedding it (pointing to built preview for the current fork):
To embed it after merge: