Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.13 in workflows #9523

Merged
merged 4 commits into from
Oct 12, 2024
Merged

python 3.13 in workflows #9523

merged 4 commits into from
Oct 12, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jul 1, 2024

time to find out what is broken at python 3.13

@dimbleby
Copy link
Contributor Author

dimbleby commented Jul 1, 2024

could be worse:

@radoering
Copy link
Member

and some encoding warnings

Can you tell me where I see these warnings? I thought it should be visible for example in the Ubuntu Python 3.13 pytest job when I expand Run poetry run pytest --integration -v and scroll down but there is only a datetime warning. (Still wondering why I cannot find any warnings in #8893, cf #8893 (comment))

@dimbleby
Copy link
Contributor Author

dimbleby commented Jul 7, 2024

I might have mixed up poetry and poetry-core, PYTHONWARNDEFAULTENCODING is only turned on in poetry-core

eg in the poetry-core pull request https://github.com/python-poetry/poetry-core/actions/runs/9750266660/job/26909309129?pr=742

Run poetry run python -m pytest -p no:sugar --integration -q tests/integration
/home/runner/.local/share/pypoetry/venv/lib/python3.13/site-packages/poetry/utils/env/base_env.py:338: EncodingWarning: 'encoding' argument not specified.
output = subprocess.check_output(

but this is also true in the 3.12 test so perhaps nothing much to do with 3.13

@dimbleby
Copy link
Contributor Author

dimbleby commented Aug 6, 2024

re-ran following the release of cffi 1.17.0, pretty much working now.

Just one over-specified testcase that mysteriously is ever so slightly different on macos python 3.13.

@radoering
Copy link
Member

Just one over-specified testcase that mysteriously is ever so slightly different on macos python 3.13.

I assume we should just make the test more robust to allow any order in the output because cleo, tomlkit and pendulum are all installed in parallel.

@dimbleby
Copy link
Contributor Author

dimbleby commented Oct 3, 2024

or, maybe, make the tests run with a worker pool of size one so that they are not exposed to this sort of thing

(I did take a brief look back in August and remember being puzzled as to what was going on, not expecting to try again though)

@Secrus Secrus added this to the Poetry 2.0 milestone Oct 6, 2024
@radoering radoering merged commit 6c43ac3 into python-poetry:main Oct 12, 2024
87 checks passed
@dimbleby dimbleby deleted the python313 branch October 12, 2024 11:09
@radoering radoering added the backport/1.8 Backport a PR to 1.8 through an automated PR label Oct 12, 2024
@poetry-bot
Copy link

poetry-bot bot commented Oct 12, 2024

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9523-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c43ac34b047f186006d5731e9119cbc2f03144d
# Push it to GitHub
git push --set-upstream origin backport-9523-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-9523-to-1.8.

radoering pushed a commit to radoering/poetry that referenced this pull request Oct 12, 2024
Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit 6c43ac3)
radoering pushed a commit to radoering/poetry that referenced this pull request Oct 12, 2024
Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit 6c43ac3)
radoering pushed a commit to radoering/poetry that referenced this pull request Oct 12, 2024
Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit 6c43ac3)
radoering pushed a commit to radoering/poetry that referenced this pull request Oct 12, 2024
Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit 6c43ac3)
radoering pushed a commit that referenced this pull request Oct 12, 2024
Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit 6c43ac3)
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8 Backport a PR to 1.8 through an automated PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants