Trust the setup reader when it finds no requirements #9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
trust-setup-reader
branch
from
b01d767
to
c317273
Compare
radoering
reviewed
Feb 25, 2024
abn
force-pushed
the
trust-setup-reader
branch
from
c317273
to
5223b2b
Compare
abn
approved these changes
Feb 25, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #9000
the setup reader should now be failing if it is not confident about the answers that it is giving: so when it says that a package has no requirements we can believe it rather than assuming that we need to build that package to make sure.
gives a nice speed-up in the cases where it happens eg
petnameis a package out in the wild that has the necessary properties if you want to try it: on my computerpoetry add --lock --no-cache petnamegoes from about 8 seconds to about 1 second