Improve venv shell activation in fish shell #8804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mimicking a user typing the command we use fish's builtin
--init-command
option. This is similar to howpoetry
already does it innushell
. This makes the experience a bit nicer because instead of it looking something like this:it now looks like this (notice the missing
source
invokation)The
--init-command
option has been released withfish
version2.7b1
in 2017 according to their changelog so in my opinion should not cause compatibility issues.I didn't find any tests for the nu behavior but would add tests for this if wanted and with some small pointers about how you would like this to be tested.