-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add source validation in poetry check
#8709
add source validation in poetry check
#8709
Conversation
Checking for inconsistent sources is not that easy. For example, the following inconsistent sources are not detected:
and even worse, the following consistent sources are detected as inconsistent (same for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking for not existing sources is probably ok, but checking for inconsistent sources can lead to false positives (see #8709 (comment)).
Thanks, @radoering. It's definitely more intricate than I initially anticipated. I'm going to delve deeper to explore potential solutions. Meanwhile, I would like to separate the pull request (PR) and create an independent one specifically for Checking for non-existing sources. |
03ec9db
to
3b8c9ad
Compare
@radoering, I've updated the pull request to focus on checking for sources that don't exist. While making changes, I realized that moving the logic to Lines 357 to 379 in 0578ed8
|
IMO, it's good as is. Moving it into the factory means that it is always executed (performance) and prevents any command. I think neither of these is necessary or wanted. Edit: We could put it beyond |
3b8c9ad
to
03e11a1
Compare
@radoering I have updated the implementation to support multiple-constraints dependency. Test case modified as well. |
9596860
to
543268b
Compare
543268b
to
14bc6de
Compare
14bc6de
to
fd21a8c
Compare
fd21a8c
to
156267d
Compare
poetry check
poetry check
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
poetry check
does not consider the package source #8704twoone types of source validation inpoetry check
Invalid source "{source}" referenced in dependencies.
which means a dependency referenced to not exist sourceDependency "{k}" referenced to inconsistence sources.
which means a dependency referenced to more than one source