Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read description field from setup files #8545

Merged

Conversation

ento
Copy link
Contributor

@ento ento commented Oct 16, 2023

Pull Request Check List

No corresponding issue in the issue tracker.

  • Added tests for changed code.
  • Updated documentation for changed code.

I work with a project that has a local path dependency and noticed that the description of the local package would get added or removed from poetry.lock seemingly at random when a new dependency was added or otherwise got updated. The local path dependency uses setup.py for historical reasons, and I've identified at least one path in which the description field becomes empty, which is when its metadata gets extracted through static analysis.

Minimally reproducible example: https://github.com/ento/poetry/tree/mcve-setup-py-missing-description
Running poetry lock using the current master branch (f5cb9f0) produces a lock file with an empty description for the local path dependency like so:

[..]
[[package]]
name = "localpackage"
version = "0.0.1"
description = ""
[..]

This PR updates the SetupReader class to fetch the description field just like how it reads the package name field.

@radoering radoering force-pushed the read-description-from-setup-files branch from 804d16f to 412d5d4 Compare October 17, 2023 17:51
@radoering radoering merged commit 611033a into python-poetry:master Oct 17, 2023
20 checks passed
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants