Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.12 is out #8543

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

dimbleby
Copy link
Contributor

No description provided.

@radoering
Copy link
Member

Have you already taken a look at the deprecation warnings with Python 3.12? I suppose we want to fix at least the warnings that are not just in the tests before the next release?

tests/utils/test_authenticator.py: 73 warnings
  /home/runner/work/poetry/poetry/.venv/lib/python3.12/site-packages/httpretty/core.py:1077: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    now = datetime.utcnow()

tests/repositories/test_pypi_repository.py: 2 warnings
tests/installation/test_chef.py: 1 warning
tests/repositories/test_legacy_repository.py: 5 warnings
tests/puzzle/test_solver.py: 3 warnings
tests/installation/test_executor.py: 3 warnings
tests/installation/test_installer.py: 1 warning
  /opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/tarfile.py:2220: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.
    warnings.warn(

tests/integration/test_utils_vcs_git.py: 10 warnings
  /home/runner/work/poetry/poetry/src/poetry/utils/helpers.py:64: DeprecationWarning: onerror argument is deprecated, use onexc instead
    shutil.rmtree(path, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@dimbleby
Copy link
Contributor Author

I didn't look at the deprecations. 3.14 is a way off!

They don't look as though they should be particularly challenging; but I don't see that it's essential to fix them before the next release. The current poetry is already out there, some people are likely running it at python 3.12, deprecation warnings are only warnings.

meanwhile I guess it's better to have the pipelines revealing these things than not

@dimbleby
Copy link
Contributor Author

#8544 adds a commit that deals with those deprecations that come from this codebase

@radoering radoering merged commit f5cb9f0 into python-poetry:master Oct 16, 2023
20 checks passed
@dimbleby dimbleby deleted the python-3.12-is-out branch October 16, 2023 06:46
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants