Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry shell: fix nushell #8478

Merged
merged 2 commits into from
Oct 6, 2023
Merged

poetry shell: fix nushell #8478

merged 2 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. poetry shell: fix nushell 

    Presently, there are two bugs with `poetry shell` on nushell:

1. The `overlay use` command that poetry sends to the subshell does not
   get run, but merely appears on the command line as if the user had
   typed it themselves. Hitting the enter key is still necessary to
   activate the virtualenv.
2. In the subshell, whenever the user uses a tool that requires
   interactive keyboard input, the input is not echoed on the screen.
   This is because the current code specifically and explicitly turns
   off the terminal echo mode. It is unclear why.

This change fixes both of these problems by changing the invocation of
`nu` to run the `overlay use` command with the `-e` flag, which runs the
given command and then starts an interactive shell.

Disabling echo mode is also removed.
    @dead10ck @radoering
    dead10ck authored and radoering committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ac8a9f5 View commit details
    Browse the repository at this point in the history

  2. coding style

    @radoering
    radoering committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7f1a065 View commit details
    Browse the repository at this point in the history