Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-cache-dir to user-facing error message about PEP-517 support. #8463

Merged
merged 5 commits into from
Sep 23, 2023
Merged

Add --no-cache-dir to user-facing error message about PEP-517 support. #8463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c3a2a7
Add --no-cache-dir to prevent false positives of PEP-517 support.
itsjamie Sep 22, 2023
d63d069
Add --no-cache-dir to executor test.
itsjamie Sep 22, 2023
6dc9090
Resolve linting issue of line too long.
itsjamie Sep 22, 2023
26cc122
minor refactoring
radoering Sep 23, 2023
4aec511
remove unnecessary line break
radoering Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/poetry/installation/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def _execute_operation(self, operation: Operation) -> None:
trace.render(io)
if isinstance(e, ChefBuildError):
pkg = operation.package
pip_command = "pip wheel --use-pep517"
pip_command = "pip wheel --no-cache-dir --use-pep517"
if pkg.develop:
requirement = pkg.source_url
pip_command += " --editable"
Expand Down
4 changes: 2 additions & 2 deletions tests/installation/test_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,11 +1290,11 @@ def test_build_backend_errors_are_reported_correctly_if_caused_by_subprocess(

assert directory_package.source_url is not None
if editable:
pip_command = "pip wheel --use-pep517 --editable"
pip_command = "pip wheel --no-cache-dir --use-pep517 --editable"
requirement = directory_package.source_url
assert Path(requirement).exists()
else:
pip_command = "pip wheel --use-pep517"
pip_command = "pip wheel --no-cache-dir --use-pep517"
requirement = f"{package_name} @ {path_to_url(directory_package.source_url)}"
expected_end = f"""
Note: This error originates from the build backend, and is likely not a problem with \
Expand Down