Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare tests for Python 3.12 PyPI trove classifier #8376

Closed
wants to merge 2 commits into from
Closed

Prepare tests for Python 3.12 PyPI trove classifier #8376

wants to merge 2 commits into from

Conversation

jakob-keller
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

python-poetry/poetry-core#631 adresses #8375, but currently fails poetry downstream tests.

This PR prepares poetry unit tests for python-poetry/poetry-core#631.

@jakob-keller jakob-keller changed the title Python 3.12 classifier Prepare tests for Python 3.12 PyPI trove classifier Aug 28, 2023
@jakob-keller
Copy link
Contributor Author

Tests are expected to fail. This PR is intended to work in conjuncture with python-poetry/poetry-core#631.

@radoering
Copy link
Member

I tend to think that we should make these tests more generic so we avoid the dance for each new Python version:
We could change the expectation in the tests to all Python versions in Package.AVAILABLE_PYTHONS that are allowed by the test's Python constraint.

@jakob-keller
Copy link
Contributor Author

I tend to think that we should make these tests more generic so we avoid the dance for each new Python version:
We could change the expectation in the tests to all Python versions in Package.AVAILABLE_PYTHONS that are allowed by the test's Python constraint.

You're absolutely right. I'll try to address that tonight.

@jakob-keller
Copy link
Contributor Author

Superseded by #8397

@jakob-keller jakob-keller deleted the python-3.12-classifier branch September 1, 2023 18:18
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants