Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache corruption due to broken connections, where of the wheel is only .. (Master resolves the issue same way) #8235

Closed
wants to merge 1 commit into from

Conversation

abi-jey
Copy link

@abi-jey abi-jey commented Jul 24, 2023

This issue occurs mostly when having unstable connections and package is only half downloaded and it causes cache corruption. Raising a runtime error will fix the issue as it does not cause hash issues while retrying the install

Pull Request Check List

Resolves: #7881

… of the wheel is downloaded

This issue occurs mostly when having unstable connections and causes cache corruption. Raising a runtime error will fix the issue as it does not cause hash issues while retrying the install
@dimbleby
Copy link
Contributor

urllib3/urllib3#2514 defaults enforce_content_length to True for urllib3 2.0, and the main branch of poetry allows urllib3 2.0.

So this should be fixed automatically in the next release without needing to write any code?

@abi-jey
Copy link
Author

abi-jey commented Jul 24, 2023

@dimbleby but does poetry include urllib3 >= 2.0 ? Would it be acceptable to have a hard check by poetry as well as through urllib3, it wouldn't cause any conflict I suppose

@dimbleby
Copy link
Contributor

dimbleby commented Jul 24, 2023

the main branch of poetry doesn't require any particular version of urllib3 because it is only an indirect dependency; but urllib3 2.0..4 is what you get if you install poetry from that main branch today

@abi-jey
Copy link
Author

abi-jey commented Jul 24, 2023

@dimbleby Just tried the main branch and it solves the issue perfectly

@abi-jey
Copy link
Author

abi-jey commented Jul 24, 2023

I will close this as it resolves itself with next release

@abi-jey abi-jey closed this Jul 24, 2023
@abi-jey abi-jey changed the title fix: cache corruption due to broken connections, where of the wheel is only partially downloaded fix: cache corruption due to broken connections, where of the wheel is only .. (Master resolves the issue same way) Jul 24, 2023
@abi-jey
Copy link
Author

abi-jey commented Jul 24, 2023

@dimbleby when do you think next release happens?

@dimbleby
Copy link
Contributor

no idea, I have no more influence on that than you do. Watch #8232 I guess

@abi-jey
Copy link
Author

abi-jey commented Jul 24, 2023

@dimbleby yep just saw there is an issue for it

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent Hash Validation Failures
2 participants