fix: fix url dependency caching when special urlencoded chars #7921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix over #7693, ideally to be included in 1.5.0 as well.
Noticed that the url dependency caching behaviour was broken when special characters (
+
in the example) are part of the url. Taking the usual PyTorch as example (👀):torch-2.0.0%2Bcpu-cp39-cp39-linux_x86_64.whl
torch-2.0.0+cpu-cp39-cp39-linux_x86_64.whl
thus rendering the caching mechanism useless.
The fix correctly stores the wheel on filesystem as
torch-2.0.0+cpu-cp39-cp39-linux_x86_64.whl
, making the cache great again.Didn't mind adding a test as using
Link
should be the general way to go around the codebase instead of usingos
andurllib
directly.