inspection.info: simplify get_pep517_metadata #7703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
force-pushed
the
redo-pep517-metadata
branch
from
5b3f39f
to
eea8e51
Compare
FFY00
changed the title
FFY00
force-pushed
the
redo-pep517-metadata
branch
from
eea8e51
to
db1ac1c
Compare
Signed-off-by: Filipe Laíns <[email protected]>
FFY00
force-pushed
the
redo-pep517-metadata
branch
2 times, most recently
from
0710780
to
b58ce8e
Compare
|
related #7670, which takes a complementary approach: if poetry can understand pep-621 compliant pyproject.toml well enough to read the metadata from it directly then there's no need to install in this code path at all. probably there's room for both, I've no idea whether that other has stalled or is only resting. |
Signed-off-by: Filipe Laíns <[email protected]>
FFY00
force-pushed
the
redo-pep517-metadata
branch
from
b58ce8e
to
975f1ad
Compare
|
Superseded by #9168 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6154, #7702
This patch simplifies
get_pep517_metadata, makes it more efficient, and make sure we handle the build dependencies corrently on legacy (setup.py) projects.