-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove cachy dependency and cache compatiblity tests #7437
Conversation
6a95ed9
to
bb2bace
Compare
I'm not sure this is something we want; at least not for now. To remove cachy, I think I'd prefer to see tests that ensure we gracefully handle a 'corrupt' cache. |
Alright. I didn't realize how long term the cache actually is. So my understanding now is that a cache generated by older poetry version can be used by current poetry version. I will attempt to look into that graceful handling. In the meanwhile, would it be acceptable to modify the tests such that cachy test would be skipable? At this time cachy is imported in conftest, so I don't think there is any good way to achieve that. |
Would you care to explain why is this such a great matter to you? |
It's not that the cache is long-lived, is that historically a invalid cache file jams Poetry until the cache is cleared. As such we need to make sure to feed our replacement for Cachy garbage input and make sure that it gracefully handles corrupt files. |
I'd like to include poetry in the Gentoo Linux package repo gentoo/gentoo#28843 |
Unfortunately, I don't think making our test suite less robust to mitigate distro packaging choices is tenable here in the upstream. If you need to bypass that test, patching it out is your best bet. Or if you want to do something mergable, I'd suggest a robust set of tests with a corpus of good and bad inputs (and maybe even some fuzzing) to ensure that we no longer hang on an invalid cache would be good. The cachy tests don't prevent the invalid cache issue today, but they do help us avoid making it worse. If we are resilient to an outdated/corrupt on-disk format, that will give us the confidence to drop this set of tests from the test suite. |
I wouldn't mean to make the tests lest robust in favor of distro packaging. That's why I said, Id rather put the effort into poetry, however unless I am missing something, the new I can understand the need for a more robust cache, but that concern would belong to #5868 (never mind the fact cachy wasn't in the first place, as you've mentioned) or filed as a separate issue. I've created #7453 in an attempt to make Cache more resilient to cache file corruption. |
bb2bace
to
26b0b65
Compare
4cf4d0d
to
733fcf4
Compare
Rebased and resolved conflicts. Is there any update on the opinion of not wanting to remove cachy tests (verifying the parity with |
9977042
to
bbdeed6
Compare
bbdeed6
to
9a8ca5e
Compare
0f048d6
to
1059496
Compare
Rebased and resolved conflicts. |
@martin-kokos could you rebase and resolve conflicts? I guess it's time to merge this |
1059496
to
b2c232b
Compare
🙌 Rebased. Thanks for the ping. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: kind of related to #5720
Followup of #5868 by chadac which I am happy for. This PR removes
cachy
dependency and compatibility tests that were put in place for the transition from oldcachy.CacheManager
to the newutils.cache.FileCache
and . Cachy is an abandoned package.Added tests for changed code.Updated documentation for changed code.