Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 plugins versions #7391

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jan 22, 2023

Pull Request Check List

- [ ] Added tests for changed code.
- [ ] Updated documentation for changed code.

Dropped flake8-broken-line. We follow black for formatting anyway and this was blocking us from updating to newest flake8 version.

@radoering
Copy link
Member

this was blocking us from updating to newest flake8 version.

If we update flake8: Do we have to mention somewhere (contributing docs?) that you need at least Python 3.8 for development because the latest flake8 does not support Python 3.7 anymore?

@neersighted
Copy link
Member

poetry/docs/contributing.md

Lines 140 to 142 in daa87b2

{{% note %}}
Poetry's development toolchain requires Python 3.8 or newer.
{{% /note %}}

@neersighted neersighted merged commit 9a0b4af into python-poetry:master Jan 24, 2023
@Secrus Secrus deleted the update-pre-commit-plugins branch May 4, 2023 19:51
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants