Pre-commit hook skips because pyproject.toml is in subdirectory

[martinmiglio]

• Poetry version: Poetry (version 1.3.1)

• Python version: Python 3.11.0

• OS version and name: Windows 11

• pyproject.toml: https://gist.github.com/marmig0404/cf3c44f35ad86502ac82f104e77aab73

• I am on the latest stable Poetry version, installed using a recommended method.

• I have searched the issues of this repo and believe that this is not a duplicate.

• I have consulted the FAQ and blog for any relevant entries or release notes.

Issue

In my project, I have a poetry-check pre-commit hook (also shared in gist) which gets skipped when ran, saying:
poetry-check.........................................(no files to check)Skipped

I am almost entirely sure that this is because my pyproject.toml is in a sub-directory of my repo as only part of my project relies on it.

I would assume this is an easy fix, changing the files parameter in .pre-commit-hooks.yaml to match sub-directories too.

Or I might just be missing an argument in my hook to specify the directory, but none are mentioned on the poetry website where the hook is documented.

[dimbleby]

I would assume this is an easy fix

did you try it?

clone poetry, make the hook work, submit an MR! (or close this if it turns out not to be so easy after all)

[martinmiglio]

did you try it?

I figured I would pose the issue to see if I'm just missing an argument or something.
Currently investigating making an MR, I'm not too familiar with writing hooks...

[martinmiglio]

I think this goes much deeper than just the hook...

I can change the hook to match pyproject.toml in any sub-directory with files: .*pyproject.toml, but because the hook runs poetry check at the top level, the pypoject.toml wont be found, even if the hook is triggered.

poetry check could be made more extensible if it took the --directory argument as specified by global options for poetry commands, but atm it doesn't look like it does.

I would be looking for some support before going down this route. This is kinda stopped in its tracks unless the above step is done.

[dimbleby]

that part probably actually is easy to fix -

poetry/src/poetry/console/commands/check.py

Line 64 in 6e84663

poetry_file = Factory.locate(Path.cwd())

will be the line to change, you can compare how other commands handle the directory option

[edmerrett]

Any update on this? Where did you get to? I am running into a similar issue where poetry files are not at the root, but nested.

[martinmiglio]

Any update on this?

waiting on approval of the PR #7242

in the meantime, you could reference my branch for the pre-commit hook in your config.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.