Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit hook [poetry-export] skips because poetry.lock is in subdirectory #8162

Closed
2 tasks done
omar-araboghli opened this issue Jul 6, 2023 · 2 comments · Fixed by #8204
Closed
2 tasks done

Pre-commit hook [poetry-export] skips because poetry.lock is in subdirectory #8162

omar-araboghli opened this issue Jul 6, 2023 · 2 comments · Fixed by #8204
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@omar-araboghli
Copy link

omar-araboghli commented Jul 6, 2023 •
edited
Loading

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

The title is descriptive enough to understand the issue. This has been solved for poetry-check hook with #7239 and its PR-7242.

I assume the solution is very similar to the above mentioned issue and could look like:

files: ^(.*/)?poetry.lock$
@omar-araboghli omar-araboghli added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jul 6, 2023
@omar-araboghli omar-araboghli changed the title Pre-commit hook [poetry-check] skips because poetry.lock is in subdirectory Pre-commit hook [poetry-export] skips because poetry.lock is in subdirectory Jul 6, 2023
@bentocin
Copy link
Contributor

bentocin commented Jul 17, 2023 •
edited
Loading

I am currently preparing a PR to address handling of monorepo setups or if pyproject.toml / poetry.lock files live in sub directories.

@bentocin bentocin mentioned this issue Jul 17, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger pre-commit hooks for pyproject.toml in subfolder bentocin/poetry
2 participants
@bentocin @omar-araboghli