Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay return code as exit code when running script #6824

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

rc-mattschwager
Copy link
Contributor

Pull Request Check List

Resolves: #6801

  • Added tests for changed code.
  • Updated documentation for changed code.

I didn't see any relevant tests for the run_script functionality, so I'm not sure how best to test it. I did confirm the fix by running the relevant functionality locally and noting the correct exit code:

$ poetry run toolname --version
0.5.0
$ echo $?
1
$ poetry run python -m toolname --version
0.5.0
$ echo $?
1

Let me know the best way to add an automated test 👍

@dimbleby dimbleby mentioned this pull request Nov 4, 2022
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contribution 👍

The change looks reasonable to me. Could you please try to add a test for it?

fin swimmer

@radoering radoering changed the title Fixes #6801, relay exit code when running script Relay return code as exit code when running script Nov 16, 2022
@radoering radoering enabled auto-merge (squash) November 16, 2022 15:31
@radoering radoering merged commit 17e059e into python-poetry:master Nov 16, 2022
@rc-mattschwager
Copy link
Contributor Author

Thanks for writing a test, that looks like a doozy!

@neersighted neersighted added this to the 1.3 milestone Nov 16, 2022
@neersighted neersighted added area/cli Related to the command line impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance labels Nov 16, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit code relay fails when run command is a script
4 participants