Clarifies the dev-dependencies -> group.dev.dependencies switch in docs #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
added
area/docs
|
Deploy preview for website ready! ✅ Preview Built with commit 1485787. |
Closed
mkniewallner
reviewed
Nov 5, 2022
As written, it seemed to prioritize the older section notation without clarifying that the older syntax still works but shouldn't be used. This reorder visually prioritizes the preferred syntax as of 1.2.x while clearly explaining what the old syntax is during this transition period. The best next step here would be a clear definition of the version in which dev-dependencies will go away.
Co-authored-by: Mathieu Kniewallner <[email protected]>
mkniewallner
approved these changes
Nov 6, 2022
poetry-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
…cs (#6723) As written, it seemed to prioritize the older section notation without clarifying that the older syntax still works but shouldn't be used. This reorder visually prioritizes the preferred syntax as of 1.2.x while clearly explaining what the old syntax is during this transition period. The best next step here would be clearly defining the version in which dev-dependencies will disappear. Co-authored-by: Mathieu Kniewallner <[email protected]> (cherry picked from commit b1e1e14)
mkniewallner
pushed a commit
that referenced
this pull request
Nov 6, 2022
…cs (#6723) As written, it seemed to prioritize the older section notation without clarifying that the older syntax still works but shouldn't be used. This reorder visually prioritizes the preferred syntax as of 1.2.x while clearly explaining what the old syntax is during this transition period. The best next step here would be clearly defining the version in which dev-dependencies will disappear. Co-authored-by: Mathieu Kniewallner <[email protected]> (cherry picked from commit b1e1e14)
|
🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, it seemed to prioritize the older section notation without clarifying that the older syntax still works but shouldn't be used. This reorder visually prioritizes the preferred syntax as of 1.2.x while clearly explaining what the old syntax is during this transition period.
The best next step here would be clearly defining the version in which dev-dependencies will disappear.