keyring and virtualenv are not using calver #6505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
previously approved these changes
Sep 17, 2022
neersighted
added
area/deps
|
LGTM after a re-lock |
dimbleby
force-pushed
the
not-calver
branch
from
1bf9bb9
to
99e95f0
Compare
|
Once again conflicted by your last PR |
dimbleby
force-pushed
the
not-calver
branch
from
99e95f0
to
2b37d5e
Compare
neersighted
approved these changes
Sep 17, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyringhad a>=dependency on the grounds that it used calendar versioning: but since they have reached23.x.xthat's clearly not true.virtualenvhad a>=dependency, presumably for similar reasons. It looks as though they maybe did use calendar versioning up to 2020, but they've made plenty of releases in the last couple of years and only reached 20.16.5.I am not claiming that these projects follow semver in a way that can be relied on: but that's just how life is in the python world. Eg the virtualenv changelog regularly includes 'Features' in patch releases.
So far as adherence to semver goes, poetry and poetry-core are likely living in a glass house and should not throw any stones.
However I am claiming that it is inconsistent to use
>=for these dependencies when, so far as I can tell, they are as close to using semver as any other project.