Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix virtualenv constraint #6376

Merged

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 2, 2022

python-poetry/poetry-core#461 reveals that poetry's own pyproject.toml contained an invalid constraint:

Could not parse version constraint: (>=20.4.3

oops.

I still think that poetry-core fix is good and desirable, but if this is an indication of the likely influx of issues... well that's something to think about.

Anyway this MR is clearly good, let's fix the error here.

@dimbleby
Copy link
Contributor Author

dimbleby commented Sep 2, 2022

just to confirm:

curl -s https://pypi.org/pypi/poetry/1.2.0/json | jq ".info.requires_dist[3]"
"virtualenv"

ie poetry's metadata is asking for any version of virtualenv at all, not the constrained version that it had thought it was asking for

@neersighted neersighted enabled auto-merge (rebase) September 2, 2022 21:27
@neersighted neersighted added impact/backport Requires backport to stable branch backport/1.2 area/deps Related to representing and locking dependencies labels Sep 2, 2022
@neersighted neersighted merged commit 3d03430 into python-poetry:master Sep 2, 2022
@poetry-bot
Copy link

poetry-bot bot commented Sep 2, 2022

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6376-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d0343008ffbd3597509381b4437eeeff12bcf90
# Push it to GitHub
git push --set-upstream origin backport-6376-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6376-to-1.2.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/deps Related to representing and locking dependencies impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants