Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] Ensure repository deletion is consistent #6231

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[1.2] Ensure repository deletion is consistent #6231

merged 1 commit into from
Aug 25, 2022

Commits on Aug 25, 2022

  1. Ensure repository deletion is consistent (python-poetry#6214) 

    This change improves the consistency of `Pool().remove_repository()` to make it easier to write poetry plugins which mutate the repository pool.

1.  Deleting an element from the middle of `Pool()._repositories` decrements the index of later entries.  Update `Pool()._lookup` to reflect this.

2.  If a primary repository is deleted, decrement `Pool()._secondary_start_idx` to ensure that any additional primary repositories are still added before all secondary repositories.

3.  If the default repository is deleted, reset `Pool()._default` so a new one can be added.

Co-authored-by: Randy Döring <[email protected]>
    @jre21 @radoering @neersighted
    2 people authored and neersighted committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d708104 View commit details
    Browse the repository at this point in the history