feat(shell_support): add nushell #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@efugier please add update to new shellingham version to PR and it will be good to go I think |
efugier
force-pushed
the
feat/add-nushell-support
branch
from
d8e4583
to
c1bc2f6
Compare
efugier
force-pushed
the
feat/add-nushell-support
branch
from
c1bc2f6
to
7d90409
Compare
|
Done @Secrus! An issue remains though: the activation command isn't executed in the new shell I don't know where the issue is (on I'll see what I can do about this. |
|
Update: seem like the issue is on Nushell's side, ready when you are @Secrus |
Secrus
approved these changes
Aug 4, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #5349
I don't believe these things are tested nor documented (did a grep for
fish), correct me if I'm wrong.Still waiting for sarugaku/shellingham#57 to be effective though, but ready when he is.