Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pipenv comparison #5561

Merged
merged 1 commit into from
May 8, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented May 8, 2022

Remove the pipenv comparison:

  • poetry is big enough and mature enough to stand on its own merits, without throwing shade at other projects
  • but anyway the worked example is not true any more, pipenv solves the given constraint just fine:
$ pipenv install oslo.utils==1.4.0
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
Creating a Pipfile for this project...
Installing oslo.utils==1.4.0...
Adding oslo.utils to Pipfile's [packages]...
✔ Installation Succeeded
Pipfile.lock not found, creating...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...
✔ Success!
Updated Pipfile.lock (2b3f82)!
Installing dependencies from Pipfile.lock (2b3f82)...
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

in particular it finds oslo.i18n 2.1.0, contrary to the README's claim that only poetry is smart enough to do this

@abn abn merged commit 217599b into python-poetry:master May 8, 2022
@dimbleby dimbleby deleted the remove-pipenv-comparison branch May 8, 2022 20:41
@abn abn mentioned this pull request Jun 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants