Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #4086 to 1.1 branch #5200

Closed
wants to merge 3 commits into from
Closed

Port #4086 to 1.1 branch #5200

wants to merge 3 commits into from

Conversation

robin92
Copy link

@robin92 robin92 commented Feb 15, 2022

Resolves: #3216

  • Added tests for changed code.
  • Updated documentation for changed code.

@robin92
Copy link
Author

robin92 commented Feb 15, 2022 •
edited
Loading

Poetry 1.1.13 has issues with downloading packages from private PyPI servers hosted on Azure Artifacts. Problem manifests with a HTTP 401 Unauthorized error and seems to already have been reported and handled by #4086. However, that PR targets the master branch and next feature release but users of current stable releases are left with effectively no access to Azure Artifacts.

This PR ports the change made by @Darsstar to 1.1 branch along with some pip.py file and ephemeral_environment function from other commits (dependencies). This change has been tested on the Azure Artifacts PyPI server I have access to and it works.

TODOs:

  • correct ported function name in commit message
  • make pipeline pass

@robin92 robin92 force-pushed the fix/port-PR-4086-to-1.1 branch 3 times, most recently from 071fd32 to e0edf85 Compare February 15, 2022 12:11
@robin92 robin92 marked this pull request as ready for review February 15, 2022 13:03
@Secrus
Copy link
Member

Secrus commented May 17, 2022

Poetry team has no plan for another 1.1.x release, so it won't be backported.

@Secrus Secrus closed this May 17, 2022
@Secrus Secrus added the wontfix label May 17, 2022
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin92 @Secrus @sdispater