Fix problem with deleting temporary folders on Windows (re-created patch #1032) #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting temporary directories on Windows try a few times so we get around a Windows error, see issue python-poetry#1031 for more details.
|
Hi, @eblis are you still interested in bringing that to Poetry? |
|
If @eblis is not available then I am certainly interested, I've hit this issue several times now with our CI machines. What would need to be done? Is it just fixing the pre-commit checks? |
|
Hey, sorry, I completely missed the updates in this issue. |
|
It might be a matter of commenting Otherwise it'll need the checks fixing, see the failed check below |
2 tasks
|
From what I can tell the relevant code has been moved to another repository called |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting temporary directories on Windows try a few times so we get around a Windows error, see issue #1031 for more details.
Pull Request Check List
Resolves: #1031, #1032
Pull request #1032 is stale, but I took out the code from that and made the requested changes from comments (decreased timeout to 1s and added a test)