-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1] Ensure all hash types are checked #4529
Conversation
14c8da8
to
2c1a86b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, better mocking than my tests (you've definitely had more practice..). Reckon using the match
for pytest.raises()
would be neater.
raise RuntimeError( | ||
"Invalid hash for {} using archive {}".format(package, archive.name) | ||
"Invalid hashes ({}) for {} using archive {}. Expected one of {}.".format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this better than my single hash message.
89c9d9c
to
43b7c61
Compare
43b7c61
to
5221df9
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #4523