Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Fix archive hash generation #4444

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

sdispater
Copy link
Member

Backport of ccf1322 to the 1.1 branch.

This PR – coupled with #4420 and python-poetry/poetry-core#193 – should fix the file hashes check.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater merged commit 8268795 into 1.1 Aug 27, 2021
@sdispater sdispater deleted the 1.1-fix-archive-hash-generation branch August 27, 2021 08:45
@sdispater sdispater mentioned this pull request Sep 18, 2021
@orf
Copy link
Contributor

orf commented Sep 20, 2021

I believe this has caused #4523.

Specifically we're hard-coding sha256 here (https://github.com/python-poetry/poetry/pull/4444/files#diff-de189aa00e987348b593bd76b6498c6b1e6dbbbb69ffeaa4824a789f1e8c837eR612), which will result in failures to install any MD5-hashed dependencies.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants