Adds File existence check to Uploader #4417
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@finswimmer Please can you review my PR? |
abn
previously requested changes
Oct 8, 2021
|
Could you rebase onto |
|
Sure - I'll rebase this and update to match the suggestions :) |
|
Looks like a bad rebase. I'd suggest reverting using your reflog, fetching |
1nF0rmed
force-pushed
the
adds_check_file_existence_to_uploader
branch
from
7f9726d
to
9e0135b
Compare
neersighted
reviewed
Nov 15, 2021
1nF0rmed
force-pushed
the
adds_check_file_existence_to_uploader
branch
from
9e0135b
to
1fd7832
Compare
neersighted
previously approved these changes
Sep 18, 2022
neersighted
added
impact/changelog
|
pre-commit.ci autofix |
neersighted
reviewed
Sep 18, 2022
neersighted
previously approved these changes
Sep 18, 2022
neersighted
force-pushed
the
adds_check_file_existence_to_uploader
branch
from
77a7e3a
to
cd8457f
Compare
neersighted
approved these changes
Sep 18, 2022
This handles the TODO for checking the existence of the files being uploaded by the Uploader class. In the case that a file does not exist, it raises an UploadError. Co-authored-by: Bjorn Neergaard <[email protected]>
neersighted
force-pushed
the
adds_check_file_existence_to_uploader
branch
from
cd8457f
to
085a5ee
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the TODO for checking the existence of the files being
uploaded by the Uploader class.
poetry/poetry/publishing/uploader.py
Line 229 in c967a4a
In the case that a file does not exist, it raises a UploadError.
The raised error message is as follows:
Wheel or Tar files associated with the Project Package do not existPull Request Check List
Resolves: NA
Questions: