Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs / Basic Usage] Use PowerShell on Windows #3978

Merged
merged 1 commit into from
May 20, 2022
Merged

[Docs / Basic Usage] Use PowerShell on Windows #3978

merged 1 commit into from
May 20, 2022

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Apr 20, 2021

Further to #3372 and #3373, on Windows, you'd typically use PowerShell rather than CMD. PowerShell scripts end in .ps1 while CMD "batch scripts" end in .bat.

Also, any chance this could be pushed to the live docs anytime soon? The basic fix (#3373) was pushed to master 6 months ago, and the suggestions that you "source" the activate a virtual environment on Windows made me wonder, in charitable moments, if anyone had ever actually tried to do that, and in less charitable moments ... well ... not great things about poetry's general support of Windows.

Pull Request Check List

Resolves: #3372

  • [ n/a ] Added tests for changed code.
  • Updated documentation for changed code.

@MinchinWeb
Copy link
Contributor Author

Current docs:

image

@abn abn added the area/docs Documentation issues/improvements label May 13, 2022
@Secrus
Copy link
Member

Secrus commented May 17, 2022

@MinchinWeb could you please merge changes from master and resolve all conflicts so this PR could be re-reviewed?

@Secrus Secrus added the status/waiting-on-response Waiting on response from author label May 17, 2022
Further to #3372 and #3373, on Windows, you'd typically use PowerShell rather than CMD. PowerShell scripts end in `.ps1` while CMD "batch scripts" end in `.bat`.
@MinchinWeb
Copy link
Contributor Author

@Secrus rebased. Your turn.

@github-actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-gc7gbxsi1-python-poetry.vercel.app

Built with commit cdd6912.
This pull request is being automatically deployed with vercel-action

@Secrus Secrus requested a review from a team May 20, 2022 07:51
@abn abn removed the status/waiting-on-response Waiting on response from author label May 20, 2022
@abn abn merged commit a80f985 into python-poetry:master May 20, 2022
@MinchinWeb MinchinWeb deleted the patch-1 branch May 21, 2022 03:00
@abn abn mentioned this pull request Jun 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in activating virtualenv in Windows
3 participants