site: use importlib instead of adhoc file searches #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the CI errors on Cirrus are due to these changes. Could you take a look? |
abn
force-pushed
the
fix/pep610-case-sensitivity
branch
from
1de8de7
to
d4c9263
Compare
abn
changed the title
abn
force-pushed
the
fix/pep610-case-sensitivity
branch
2 times, most recently
from
2433f5a
to
c588f6d
Compare
This change replaces various cases in which installed distribution and file look-ups used path searches with importlib.metadata backed look-ups. This fixes issues with `dist-info` lookup for PEP610 implementation as well as `.pth` file look-up and `dist-info` removal.
abn
force-pushed
the
fix/pep610-case-sensitivity
branch
from
c588f6d
to
b66cd8e
Compare
|
@sdispater this should be good now. Instead of trying to make the previous fix work on freebsd, I ended up fixing the underlying issue. This should be good to review now. |
This was referenced Apr 9, 2021
kasteph
approved these changes
Apr 10, 2021
2 tasks
3 tasks
This was referenced Apr 14, 2021
This was referenced Jul 28, 2021
2 tasks
3 tasks
|
Hi, is this fix included in the latest version of poetry (1.1.13)? I'm still running into the issue in #2918. |
|
Same here, running into the issue! @lkev found something? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces various cases in which installed distribution and
file look-ups used path searches with importlib.metadata backed
look-ups.
This fixes issues with
dist-infolookup for PEP610 implementation aswell as
.pthfile look-up anddist-inforemoval.Resolves: #2918
Resolves: #3289
Resolves: #2855