Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools/wheels/distribute from UNSAFE_PACKAGES. Fixes #1584 #3668

Closed
wants to merge 1 commit into from

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Feb 9, 2021

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code. -- none needed.

A few tests are still failing, I think that is due to the poetry.lock update, I will have to run that in a separate commit first I guess.

@kasteph kasteph requested a review from a team February 9, 2021 22:26
@abn
Copy link
Member

abn commented Feb 9, 2021

Tjamls for the change @apollo13, in theory I think we need to do this.

This might however need a bit more testing/validation. Mostly because this will fail in some supported environments where the default venv created will not support the --use-pep-517 option. Ideally, we will have to queue this behind a change like #2826 to be safe and that is the direction we would want to go in general.

@apollo13
Copy link
Contributor Author

@abn Ok, I do not think I fully agree with you; but I am fine with pursuing #2826. I will check the PR out and test it locally. Can you please tell me what you think is missing there so I can help you get this over the finish line?

@apollo13 apollo13 closed this Feb 10, 2021
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants