Issue 3220 add develop flag for add command #3250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
reviewed
Oct 19, 2020
poetry/console/commands/add.py
Outdated
| @@ -50,6 +50,7 @@ class AddCommand(InstallerCommand, InitCommand): | |||
| "Output the operations but do not execute anything (implicitly enables --verbose).", | |||
| ), | |||
| option("lock", None, "Do not perform operations (only update the lockfile)."), | |||
| option("develop", None, "Add as dependency in editable mode."), | |||
There was a problem hiding this comment.
The documentation should also mention that this is only supported for VCS and path dependnecies.
There was a problem hiding this comment.
@abn My bad, thought documentation for cli options were automatically generated
0scarB
force-pushed
the
issue-3220-add-develop-flag-for-add-command
branch
from
ec924e5 to
87583c6
Compare
0scarB
force-pushed
the
issue-3220-add-develop-flag-for-add-command
branch
from
44ad650 to
244518b
Compare
This was referenced Apr 17, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3220
Simply adding the
developattribute causes the following issue however - only directory and vcs dependencies support thedevelopattribute.If we add
develop = truewithout checking thesource_typefirst then the follow unintuitive error message is raised for dependencies that do not support itIt would be better to raise an explicit error such as
The develop flag is not supported for dependencies of type <source_type>Unfortunately I don't see an elegant way of doing this without changing how
poetry-coredependencies handle thedevelopparameter.