Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy repository fall back redirects #3133

Closed
wants to merge 1 commit into from

Conversation

neilvana
Copy link

@neilvana neilvana commented Oct 7, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Legacy repositories may specify a fallback url if a package is contained in an upstream repository. To support this redirection we should use the url contained in the response when creating a Page object to ensure relative links are properly calculated.

@abn abn requested a review from a team October 7, 2020 21:20
@thejcannon
Copy link
Contributor

@abn (sorry couldn't find out how to mention the triage) anything the community can do to get this along?

This is basically the only missing piece to having us roll out poetry to all the tools at our company. We're all very eager to abandon our tox+requirements+setup.py solution for poetry ❤️

@sinoroc
Copy link

sinoroc commented Dec 11, 2020

Looks like it is the same issue as #3293 and looks like it is the same fix as suggested in #3198.

Maybe the authors of both PRs can agree on something here.

@neilvana
Copy link
Author

I've left comments on #3198. I plan to discard this PR if that one is accepted.

@neilvana
Copy link
Author

Since progress is being made in #3198 I'm closing this PR in favor of that one.

@neilvana neilvana closed this Dec 15, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants