Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show: ignore dependency source when finding package #3117

Merged
merged 1 commit into from
Oct 13, 2020
Merged

show: ignore dependency source when finding package #3117

merged 1 commit into from
Oct 13, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 7, 2020

Resolves: #3116

@abn abn added the kind/bug Something isn't working as expected label Oct 7, 2020
@abn abn added this to the 1.1 milestone Oct 7, 2020
@abn abn requested a review from a team October 7, 2020 13:37
@abn abn mentioned this pull request Oct 7, 2020
Closed
3 tasks
finswimmer
finswimmer requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to add a useful test for it?

@abn
Copy link
Member Author

abn commented Oct 8, 2020

TBH; testing this will be convoluted. And far more effort than worth it I feel.

@wasdee wasdee mentioned this pull request Oct 9, 2020
Closed
3 tasks
@abn abn requested a review from finswimmer October 12, 2020 19:06
@finswimmer finswimmer merged commit 50e0628 into python-poetry:1.1 Oct 13, 2020
@abn abn deleted the issue/3116 branch October 13, 2020 18:42
This was referenced Oct 14, 2020
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@abn @finswimmer