Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.md #2829

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Update pyproject.md #2829

merged 2 commits into from
Aug 20, 2020

Conversation

noamraph
Copy link
Contributor

Explain that poetry install installs the scripts in the virtualenv. See #2179 for the use case.

Having a script inside the virtualenv allows it to be run from a different working directory. Both @bphunter1972 and I didn't think about running poetry install in order to create the script. So I think that saying this explicitly may help others as well.

Explain that `poetry install` installs the scripts in the virtualenv. See python-poetry#2179 for the use case.
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider making this a note? I think it is important enough to be marked as such.

docs/docs/pyproject.md Outdated Show resolved Hide resolved
Co-authored-by: Arun Babu Neelicattu <[email protected]>
@noamraph
Copy link
Contributor Author

Maybe consider making this a note? I think it is important enough to be marked as such.

@abn Sure!

@bphunter1972
Copy link

Doesn't poetry install install the scripts NOT into the virtual environment, but into the user's .local/bin (LINUX)?

More generally, isn't this correct:

  • poetry shell creates a shell in the virtual environment which has your libraries and scripts.
  • poetry install installs the the libraries and scripts into your system, which for me was my .local directory.

That's what worked for me.

@finswimmer finswimmer merged commit 5de6203 into python-poetry:master Aug 20, 2020
@noamraph
Copy link
Contributor Author

@bphunter1972 at least for me, poetry install added scripts to the virtualenv's bin directory.

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants