Skip to content

Run python -m pip instead of pip#262

Closed
Tonkonozhenko wants to merge 2 commits intopython-poetry:masterfrom
Tonkonozhenko:master
Closed

Run python -m pip instead of pip#262
Tonkonozhenko wants to merge 2 commits intopython-poetry:masterfrom
Tonkonozhenko:master

Conversation

@Tonkonozhenko
Copy link

When you try to run pip in venv in a directory with a long full path you get an error. To avoid this you need to run python -m pip instead of pip.

@sdispater
Copy link
Member

Thanks!

Could you execute black on the poetry/console/commands/develop.py file to make the build pass on Travis?

Also, could you rebase your PR on the develop branch?

@Tonkonozhenko
Copy link
Author

I've fixed formatting, but I'm getting an error in travis, hope you can help with it.

@daa
Copy link

daa commented Jun 29, 2018

I had similar issue with tox and found it to be better to call /path/to/python/python /path/to/pip/pip or to put virtualenv to directory with shorter name. Related tox ticket with conversation - https://bitbucket.org/hpk42/tox/issues/66/tox-shouldnt-call-pip-directly-to-avoid .

@daa
Copy link

daa commented Jul 18, 2018

I'd like to inform you that tox recently got a workaround for such cases - tox-dev/tox#794

@daa
Copy link

daa commented Aug 10, 2018

And recently tox moved to using python -m pip by default (tox-dev/tox#935).

@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 15, 2019
Copy link
Contributor

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tonkonozhenko Thanks for this contribution!

To get this across the finish line we need to do the following:

Update the mock used in testing here
Manually test that this works when not mocked

@debdolph
Copy link

Works for me. Thank you!

@ghost
Copy link

ghost commented Sep 10, 2019

Hello. How should we proceed with this PR?

@stale
Copy link

stale bot commented Nov 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2019
@sdispater sdispater added stale and removed wontfix labels Nov 14, 2019
@stale stale bot removed the stale label Nov 14, 2019
@K900
Copy link
Contributor

K900 commented Nov 28, 2019

FYI, this is completely obsoleted now.

@finswimmer finswimmer closed this Nov 30, 2019
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/feature Feature requests/implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants