Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell.py to support tcsh #2583

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Update shell.py to support tcsh #2583

merged 1 commit into from
Jun 19, 2020

Conversation

JnyJny
Copy link
Contributor

@JnyJny JnyJny commented Jun 19, 2020

These small changes allow poetry shell to properly activate a python virtual environment when the user's shell is tcsh.

Pull Request Check List

Resolves: #2584

  • Added tests for changed code.
  • Updated documentation for changed code.

These small changes allow `poetry shell` to properly activate a python virtual environment when the user's shell is `tcsh`.
@JnyJny
Copy link
Contributor Author

JnyJny commented Jun 19, 2020

Also, I am apparently the last tcsh user left on the planet. :so alone:

@abn abn merged commit e76796b into python-poetry:master Jun 19, 2020
@JnyJny JnyJny deleted the patch-1 branch June 19, 2020 21:45
@sdispater sdispater mentioned this pull request Jul 21, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry shell command does not activate the virtual environment when the user's shell is tsch
2 participants