Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable ssl verify (Poetry 1.0.x) #2473

Conversation

Celeborn2BeAlive
Copy link
Contributor

Pull Request Check List

Resolves: #1556

  • Added tests for changed code.
  • Updated documentation for changed code.

Here is a proposition to disable SSL verification that makes poetry easier to use in corporate environments.

So unfortunately I started from master because the contributing guide https://python-poetry.org/docs/contributing/#how-to-contribute does not mention to start from develop.

I tried to reproduce the contrib on top of develop this morning but I must admit I gave up after noticing that poetry now depends on poetry-core having its own repository. I guess it would not be hard to add what's needed in poetry-core, but since I don't know the codebase it takes me time walking in the debugger to understand what's going on. The exception I had from poetry-core was related to the trusted field I've added that is not recognized, so modifying poetry-schema.json in poetry is not enough anymore, something must be done in the code and I didn't invastigated much. The commit I made on top of develop is available on top of this other branch: https://github.com/Celeborn2BeAlive/poetry/commits/option-to-disable-ssl-verify-develop

About tests I had no clear idea how to test this feature automatically. I did manual tests on one of our internal project that depends on packages from a private and repository and it did work.

Finally I modified the documentation but had issues building it: the resulting website does not contain valid html and is basically just a subpart of the html of the official documentation. Is there another step to build the full website ?

@finswimmer finswimmer added the kind/feature Feature requests/implementations label Jun 1, 2020
@finswimmer finswimmer requested a review from a team June 1, 2020 06:13
@maayanbar13
Copy link
Contributor

I tried to reproduce the contrib on top of develop this morning but I must admit I gave up after noticing that poetry now depends on poetry-core having its own repository. I guess it would not be hard to add what's needed in poetry-core, but since I don't know the codebase it takes me time walking in the debugger to understand what's going on. The exception I had from poetry-core was related to the trusted field I've added that is not recognized, so modifying poetry-schema.json in poetry is not enough anymore, something must be done in the code and I didn't invastigated much. The commit I made on top of develop is available on top of this other branch: https://github.com/Celeborn2BeAlive/poetry/commits/option-to-disable-ssl-verify-develop

Opened PR into poetry-core here that attempts to resolve this.

@maayanbar13
Copy link
Contributor

@Celeborn2BeAlive , I've added some tests to your branch targeting develop , feel free to check it here.

@Celeborn2BeAlive Celeborn2BeAlive changed the title Option to disable ssl verify Option to disable ssl verify (Poetry 1.0.x) Sep 13, 2020
@Celeborn2BeAlive
Copy link
Contributor Author

Closing this one in favor of /pull/2912

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable SSL verify
3 participants