Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the self update command to handle future versions #2429

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

sdispater
Copy link
Member

Pull Request Check List

The self update command needed an update to be able to handle the next feature release seamlessly. The poetry scripts has changed on the develop branch to handle the changes done to have namespaces packages, so, to avoid making people use the get-poetry.py script and keep using the self update command, we needed to generate and install the new script via the command.

This also include the changes made to the get-poetry.py script in #1878 (backported to masterin #2426) to properly detect which Python executable referenced in the poetry script .

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added Installer kind/enhancement Not a bug or feature, but improves usability or performance labels May 15, 2020
@sdispater sdispater force-pushed the update-self-update-script branch 4 times, most recently from fec197b to b6cc13a Compare May 15, 2020 15:00
@sdispater sdispater requested a review from a team May 15, 2020 15:25
@sdispater sdispater merged commit 9cd16a9 into master Jun 5, 2020
@sdispater sdispater deleted the update-self-update-script branch June 5, 2020 10:35
@sdispater sdispater mentioned this pull request Jun 5, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant