-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --remove-untracked option to the install command. #2172
Add a --remove-untracked option to the install command. #2172
Conversation
bbfc6c2
to
88bfa55
Compare
Could anyone have a look at this? I am happy to finish this up with tests and documentation. |
4200711
to
d717e0b
Compare
I'm not a poetry team member, but I took a quick look at this anyway, and I have to say you did a thorough job as far as I can tell 👍 |
Thanks Matt! @stephsamson, do you think you could take a look? |
How does this handle packages like pip and setuptools which are not in lock file but should be kept in venv? |
This is a great question and the answer is that, it did not, but currenty does! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but this feature was not in the original roadmap -- I'll defer to @sdispater on this one.
@sdispater did you have a chance to look at this? This is functionality that we really would like to have in poetry (we used Thanks, |
Is there something I could do here, besides waiting for a review? We'd love to have this in Poetry! |
Bumping this cause we're super interested in this |
Yes, the lack of this flag has been a pain point in my team since we switched from pipenv to poetry. People are How can we proceed here? @stephsamson @sdispater @finswimmer |
72b8fab
to
2bd022f
Compare
2bd022f
to
c4a2c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinging, sometimes things slip through the cracks and we forget. But thank you for the patience :)
One comment when I ran this by @sdispater: it can be improved by transferring most of the logic to the Solver
class where it should reside and it should take care of the sensitive packages.
@stephsamson Done. Moved the logic to the solver. We needed this option yesterday, when having issues with our cached CI environments. :-) Wonder if we can get this into 1.1? |
Co-authored-by: Steph Samson <[email protected]>
Done |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #648.
As discussed in the linked issue. @finswimmer seemed to approve this flag, @sdispater.
This is a feature that we are missing since moving away from pipenv. Removing old packages is part of reproducibility.