Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to find shell via os.environ if detect_shell fail (#2115) #2147

Merged
merged 3 commits into from
Apr 6, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix (utils.shell): pass error message when finding shell via environm…
…ent variable fails as well
finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Mar 9, 2020

Verified

This commit was signed with the committer’s verified signature.
sdispater Sébastien Eustace
commit 8c3a07134539b944ad3e5f75f71185b500784148
2 changes: 1 addition & 1 deletion poetry/utils/shell.py
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ def get(cls): # type: () -> Shell
elif os.name == "nt":
shell = os.environ["COMSPEC"]
else:
raise RuntimeError
raise RuntimeError("Unable to detect the current shell.")

name, path = Path(shell).stem, shell
except RuntimeError: