Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-freeze option to poetry export #2013

Closed
wants to merge 1 commit into from

Conversation

gsemet
Copy link

@gsemet gsemet commented Feb 10, 2020

  • Added tests for changed code.
  • Updated documentation for changed code.

Hi. This is my fist little submission.
This PR provides a solution for #2009. This allows to generate a requirements.txt without frozen version in it, so that user can keep requirements.txt when building a setuptools package using for example PBR.

@gsemet gsemet force-pushed the dev/gsemet branch 2 times, most recently from 4ccec6d to 8ce13bc Compare February 10, 2020 17:11
* add '--no-freeze' option to export

* add tests for 'export --no-freeze'
@finswimmer finswimmer added the kind/feature Feature requests/implementations label Feb 10, 2020
@kapilt
Copy link

kapilt commented Feb 18, 2020

so rather than just using a completely unpinned name, i think this should include the pyproject.toml dependency specification if its a direct dep, albeit translated to some minimal pip compatible semantic (https://www.python.org/dev/peps/pep-0440/#version-specifiers)

@gsemet
Copy link
Author

gsemet commented Feb 18, 2020

Yes I mean what I give as restriction in pyproject.toml

@@ -96,6 +99,9 @@ def _export_requirements_txt(
line = "{}".format(package.source_url)
if package.develop and package.source_type == "directory":
line = "-e " + line
elif no_freeze:
dependency = package.to_dependency()
line = package.name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaics, this strips the dependency to just being the naked package name, sans the pyproject.toml specification.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, it would be great to move soft deps like 1.0.* as is too.

@Secrus
Copy link
Member

Secrus commented May 21, 2022

Export was moved to poetry-plugin-export package. Please refer to it with further issues and PRs.

@Secrus Secrus closed this May 21, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants