Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git): get commit sha of git commit from annotated tags #1948

Merged
merged 3 commits into from
Feb 21, 2020
Merged

fix(git): get commit sha of git commit from annotated tags #1948

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc81962
fix(git): have annotated tags resolve to the commit sha
jrmlhermitte Jan 26, 2020
3159f92
fix(git): fix quote
jrmlhermitte Jan 26, 2020
8821c19
fix(git): change to rev-parse
Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion poetry/vcs/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,9 @@ def rev_parse(self, rev, folder=None): # type: (...) -> str
folder.as_posix(),
]

args += ["rev-parse", rev]
# We need "^{commit}" to ensure that the commit SHA of the commit the
# tag points to is returned, even in the case of annotated tags.
args += ["rev-parse", rev + "^{commit}"]

return self.run(*args)

Expand Down