Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of extra markers #1555

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

sdispater
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This fixes the way Poetry handles dependencies with opt-in extras. Basically, the extra markers were propagated to the package in the lock file but they shouldn't be.

This fixes #1313

@sdispater sdispater added the kind/bug Something isn't working as expected label Nov 8, 2019
@sdispater sdispater added this to the 1.0 milestone Nov 8, 2019
@sdispater sdispater merged commit e975b13 into master Nov 8, 2019
@sdispater sdispater deleted the fix-extra-markers-handling branch November 8, 2019 11:01
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry export -f requirements.txt adds extras to the extras.
1 participant