Improve git dependencies support #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdispater
added
kind/bug
3 tasks
shenek
pushed a commit
to shenek/poetry
that referenced
this pull request
Dec 31, 2019
* Improve the InstalledRepository class * Improve support for git dependencies
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This PR improves the way the git and path dependencies are retrieved once installed. Up until this PR it was not possible to make the distinction between path dependencies that happen to be git repositories because
pip freezewould only return the git repository url. This is now fixed by usingimportlib-metadataand some tricks to detect the dependency type by using the location.This PR also adds more git url formats when adding a dependency.