-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude nested items (#784) #1464
Merged
sdispater
merged 14 commits into
python-poetry:develop
from
finswimmer:issue-000784-exclude-nested-items
Oct 19, 2019
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9982b09
This PR impliments the feature request #784.
35603ac
use `Path` instead of `os.path.join` to create string for globbing
0834f78
try to fix linting error
e5e125a
create glob pattern string by concatenating and not using Path
1df49c8
using `os.path.isdir()`` for checking of explicit excluded name is a …
56868de
Remove nested data when wildcards where used.
a8a9c5d
fix linting
42693ca
fix linting error
ce576c7
only glob a second time if path is dir
1cd93bd
implement @sdispater 's suggestion for better readability
fa8c04f
fix glob for windows?
09af714
On Windows, testing if a path with a glob is a directory will raise a…
5617921
pathlibs glob function doesn't return the correct case (https://bugs…
38ed4d6
removing obsolete imports
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you extract the argument from
os.path.isdir
here and put it in a variable inside thisfor
-loop since we are also using the same argument forglob
in line 92?